Remove the middle man

The Trek.getEmptySector() wrapper method was added as part of an earlier refactoring. The wrapper is not needed, and can be eliminated with a Remove Middle Man refactoring. The corresponding configuration option, in TrekGameConfig, can also be removed.

Logged as issue #13

Simplify and clarify

Trek.positionKlingons() is badly named. It does far more than its name implies, and the actual positioning of enemies occurs in trek.positionEnemy(). The commented-out code should also be removed.

Logged as issue #14

Add tests for long range scans

Currently Trek.longRangeScan() is difficult to test. It might be better to move it into Galaxy, or a dedicated class.

Logged as issue #15

05-MAR-2019 👈 Top of page 👉 09-MAR-2019

© 2020 Terry Ebdon.

Find me coding on GitHub, networking on LinkedIn, answering questions on Stack Exchange and hanging out on twitter.